Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Automated cherry pick of #85555: Fix GKE upgrade test. #85658

Merged
merged 1 commit into from Nov 28, 2019
Merged

Automated cherry pick of #85555: Fix GKE upgrade test. #85658

merged 1 commit into from Nov 28, 2019

Conversation

Random-Liu
Copy link
Member

Cherry pick of #85555 on release-1.17.

#85555: Fix GKE upgrade test.

For details on the cherry pick process, see the cherry pick requests page.

@Random-Liu
Fix GKE upgrade test.
573e287 
Signed-off-by: Lantao Liu <lantaol@google.com>
@k8s-ci-robot
Copy link
Contributor

@Random-Liu: All 'parent' PRs of a cherry-pick PR must have one of the "release-note" or "release-note-action-required" labels, or this PR must follow the standard/parent release note labeling requirement.

The following parent PRs have neither the "release-note" nor the "release-note-action-required" labels: #85555.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. label Nov 26, 2019
@k8s-ci-robot k8s-ci-robot added this to the v1.17 milestone Nov 26, 2019
@k8s-ci-robot
Copy link
Contributor

@Random-Liu: Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Nov 26, 2019
@Random-Liu Random-Liu added kind/bug Categorizes issue or PR as related to a bug. and removed cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Nov 26, 2019
@k8s-ci-robot k8s-ci-robot removed the needs-kind Indicates a PR lacks a `kind/foo` label and requires one. label Nov 26, 2019
@Random-Liu Random-Liu added the priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. label Nov 26, 2019
@k8s-ci-robot k8s-ci-robot removed the needs-priority Indicates a PR lacks a `priority/foo` label and requires one. label Nov 26, 2019
@Random-Liu Random-Liu added the sig/testing Categorizes an issue or PR as relevant to SIG Testing. label Nov 26, 2019
@k8s-ci-robot k8s-ci-robot added area/e2e-test-framework Issues or PRs related to refactoring the kubernetes e2e test framework area/test and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Nov 26, 2019
@Random-Liu Random-Liu added release-note-none Denotes a PR that doesn't merit a release note. and removed area/e2e-test-framework Issues or PRs related to refactoring the kubernetes e2e test framework area/test do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Nov 26, 2019
neolit123
neolit123 reviewed Nov 26, 2019
View reviewed changes
Copy link
Member

@neolit123 neolit123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 26, 2019
@BenTheElder
Copy link
Member

/approve

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 27, 2019
@fejta-bot
Copy link

Unknown CLA label state. Rechecking for CLA labels.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/check-cla

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Nov 27, 2019
@Random-Liu
Copy link
Member Author

/test pull-kubernetes-integration

@justaugustus
Copy link
Member

Release Managers approval:
/lgtm
/approve

@justaugustus justaugustus added cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. and removed do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. labels Nov 28, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: BenTheElder, justaugustus, Random-Liu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit f0e172d into kubernetes:release-1.17 Nov 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@neolit123 neolit123 neolit123 left review comments

@krzyzacy krzyzacy Awaiting requested review from krzyzacy

Assignees

@neolit123 neolit123

@justaugustus justaugustus

@feiskyer feiskyer

@BenTheElder BenTheElder

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. release-note-none Denotes a PR that doesn't merit a release note. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
v1.17
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@Random-Liu @k8s-ci-robot @BenTheElder @fejta-bot @justaugustus @neolit123 @feiskyer